Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cucumber. again. #398

Merged
merged 19 commits into from
Jan 13, 2023
Merged

fix: cucumber. again. #398

merged 19 commits into from
Jan 13, 2023

Conversation

vobu
Copy link
Contributor

@vobu vobu commented Jan 12, 2023 •
edited
Loading

don't fiddle with the global console and just do a colored console.log

@vobu vobu requested a review from Siolto January 12, 2023 14:48
Siolto
Siolto approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@Siolto Siolto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me 👍 . Let's hope that this painful issue is now history!

@vobu
ci: try reducing concurrency
fe28493 
for constantly flaking tests...grmpf
@vobu vobu merged commit a6123eb into main Jan 13, 2023
@vobu vobu deleted the fix/cucumber-again branch January 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siolto Siolto Siolto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vobu @Siolto